Skip to content

chore: Fix UP006 #7633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

chore: Fix UP006 #7633

merged 1 commit into from
Apr 14, 2025

Conversation

honnix
Copy link
Contributor

@honnix honnix commented Apr 14, 2025

This is a follow-up PR for #7628 where UP006 was ignored temporarily.

It turns out there aren't many UP006 violations (I enabled --unsafe-fixes (https://docs.astral.sh/ruff/rules/non-pep585-annotation/) for ruff and ran pre-commit run --all-files ruff, which should apply to the whole code base IIUC).

@jtpio PTAL. Thanks.

Copy link
Contributor

Binder 👈 Launch a Binder on branch honnix/notebook/fix-UP006

@honnix honnix marked this pull request as ready for review April 14, 2025 10:06
@jtpio jtpio added this to the 7.5.0 milestone Apr 14, 2025
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit ea978c6 into jupyter:main Apr 14, 2025
33 of 37 checks passed
@honnix honnix deleted the fix-UP006 branch April 14, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants